Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase size of column-lineage.description column #2205

Merged
merged 1 commit into from
Oct 23, 2022

Conversation

pawel-big-lebowski
Copy link
Collaborator

Signed-off-by: Pawel Leszczynski leszczynski.pawel@gmail.com

Problem

Increase description column size.

Closes: #2202

Solution

Replace VARCHAR(255) with TEXT

Note: All database schema changes require discussion. Please link the issue for context.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

Signed-off-by: Pawel Leszczynski <leszczynski.pawel@gmail.com>
@boring-cyborg boring-cyborg bot added the api API layer changes label Oct 21, 2022
@@ -5,7 +5,7 @@ CREATE TABLE column_lineage (
output_dataset_field_uuid uuid REFERENCES dataset_fields(uuid),
input_dataset_version_uuid uuid REFERENCES dataset_versions(uuid), -- speed up graph column lineage graph traversal
input_dataset_field_uuid uuid REFERENCES dataset_fields(uuid),
transformation_description VARCHAR(255),
transformation_description TEXT,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can modify the column in existing migration file as long as it is not released.

@pawel-big-lebowski pawel-big-lebowski marked this pull request as ready for review October 21, 2022 12:33
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #2205 (631edf3) into main (3c26f6f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2205   +/-   ##
=========================================
  Coverage     76.61%   76.61%           
  Complexity     1136     1136           
=========================================
  Files           219      219           
  Lines          5289     5289           
  Branches        420      420           
=========================================
  Hits           4052     4052           
  Misses          765      765           
  Partials        472      472           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslulciuc wslulciuc merged commit 3f3e4ae into main Oct 23, 2022
@wslulciuc wslulciuc deleted the extend-column-lineage-description-column branch October 23, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase length of column_lineage.transformation_description column
4 participants